slick-greeter: a 'user interface' for lightdm #876
Conversation
Homepage: https://github.com/linuxmint/slick-greeter Notes: The major changes are adjustments of the display-size and ordering of the sessions defined on mariux.
| show-a11y=false | ||
| # since german is hammered into /etc/local/X11_xorg.conf, we can skip this | ||
| # (also 'de nodeadkeys' looks silly). | ||
| show-keyboard=false |
There was a problem hiding this comment.
Actually, us is our default, since we do not use /etc/X11/xorg.conf anymore. /etc/local/X11_xorg.conf is the local configuration of each system. So the user chose the keyboard layout during install time.
There was a problem hiding this comment.
Maybe the description was a bit missleading, show-keyboard=false disables the display of a non-functioning keyboard layout chooser, when on, you either get a nice keyboard-icon plus an 'us', or when overriden (hammered...) with 'de nodeadkeys'.
In ascii-art:
[::_::] us OR [::_::] de nodeadkeys
Maybe we should start trusting X to do the layout job on its own?
slick-greeter.be0
Outdated
| local slickgreeterconf=/etc/lightdm/slick-greeter.conf | ||
| mkdir -vp ${D}/etc/lightdm | ||
|
|
||
| tail -32 ${S}/README.md | sed -e 's/^\s*//' > ${D}/${slickgreeterconf} |
There was a problem hiding this comment.
Add a comment, that this is fragile?
There was a problem hiding this comment.
Better don't do it. I suggest to create the whole file verbatim and refer to the README.md insetad of copying the comments.
# LightDM GTK+ Configuration
# see https://github.com/linuxmint/slick-greeter/blob/master/README.md for available options
draw-user-backgrounds=false
play-ready-sound=false
...
There was a problem hiding this comment.
So you opt for a heredoc in the bee file?
My proposal would have been to defuse the content from the md with more pound signs at the beginning :)
There was a problem hiding this comment.
Complete file into the bee file looks better to me than to assume anything about the README.md which is targeted an human readers. We don't need comment-lines in the file. A single reference would be enough and wouldn't need to be updated.
| ## by default this may be 'make install DESTDIR="${D}"' | ||
|
|
||
| mee_install_post() { | ||
|
|
| case ${dsb} in | ||
| xfce*) | ||
| ln -v -s xfce.svg ${badgedir}/${dsb}.svg | ||
| ;; |
There was a problem hiding this comment.
Ah, sorry for xfce4_hidpi. Now I see it.
This makes upcomming rebuilds safer.
pmenzel
changed the title
|
Hi Donald, |
Homepage:
https://github.com/linuxmint/slick-greeter
Notes:
The major changes are adjustments of the display-size and
ordering of the sessions defined on mariux.